Replace Github with GitHub in CONTRIBUTING.md Section 1.4#7992
Merged
LRenDO merged 1 commit intohackforla:gh-pagesfrom Mar 19, 2025
Merged
Conversation
github-project-automation
Bot
moved this to PR Needs review
in P: HfLA Website: Project Board
|
Want to review this pull request? Take a look at this documentation for a step by step guide! Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
github-actions
Bot
added
role: front end
Member
|
Review ETA: 6 PM 3/19/25 |
Member
|
ETA: 10/18 EOD |
dvernon5
approved these changes
Mar 19, 2025
Member
There was a problem hiding this comment.
Hello @nchanyal
Thank you for taking this issue. You're contribution is greatly appreciated.
Things That Done Well
- Your PR contains the correct branch.
- You successfully linked your issue.
- The PR title is informative. Likewise, your
What changes did you makeandWhy did you make the changesare informative. Great job with the explanations! - Preview URL showed the correct changes.
- You successfully marked your action items and left you availability in the issue comment section.
You did a fantastic job on this issue!
github-project-automation
Bot
moved this from PR Needs review
to PRs ✅ waiting for merge team
in P: HfLA Website: Project Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7439
What changes did you make?
GithubwithGitHubin the first line under section 1.4.b inCONTRIBUTING.mdGithubwithGitHubin the title for section 1.4.c inCONTRIBUTING.mdGithubwithGitHubin the second line under section 1.4.c inCONTRIBUTING.mdWhy did you make the changes (we will use this info to test)?
For Reviewers: Do not review changes locally, rather, review changes at
https://github.com/nchanyal/website/blob/replace-Github-with-GitHub-in-contributing.md-7439/CONTRIBUTING.mdCodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
No visual changes to the website.